From f0b7224fdefa936b06ff5d092f109f0bd30377da Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Mon, 26 Jun 2006 10:25:14 +0000 Subject: [PATCH] Avoid a refcounting leak in the python bindings. (#344876, Phil Dumont) 2006-06-26 Matthias Clasen * gtk/gtkcombobox.c (gtk_cell_view_menu_item_new): Avoid a refcounting leak in the python bindings. (#344876, Phil Dumont) --- ChangeLog | 5 +++++ ChangeLog.pre-2-10 | 5 +++++ gtk/gtkcombobox.c | 6 +++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index f81f1cd050..c609acee5d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-06-26 Matthias Clasen + + * gtk/gtkcombobox.c (gtk_cell_view_menu_item_new): Avoid + a refcounting leak in the python bindings. (#344876, Phil Dumont) + 2006-06-25 Matthias Clasen * gtk/gtkprinter.c (gtk_enumerate_printers): Make diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index f81f1cd050..c609acee5d 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,8 @@ +2006-06-26 Matthias Clasen + + * gtk/gtkcombobox.c (gtk_cell_view_menu_item_new): Avoid + a refcounting leak in the python bindings. (#344876, Phil Dumont) + 2006-06-25 Matthias Clasen * gtk/gtkprinter.c (gtk_enumerate_printers): Make diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c index af4738dbb9..99ed8d0f43 100644 --- a/gtk/gtkcombobox.c +++ b/gtk/gtkcombobox.c @@ -2565,6 +2565,9 @@ gtk_cell_view_menu_item_new (GtkComboBox *combo_box, GtkRequisition req; cell_view = gtk_cell_view_new (); + item = gtk_menu_item_new (); + gtk_container_add (GTK_CONTAINER (item), cell_view); + gtk_cell_view_set_model (GTK_CELL_VIEW (cell_view), model); path = gtk_tree_model_get_path (model, iter); gtk_cell_view_set_displayed_row (GTK_CELL_VIEW (cell_view), path); @@ -2573,9 +2576,6 @@ gtk_cell_view_menu_item_new (GtkComboBox *combo_box, gtk_combo_box_sync_cells (combo_box, GTK_CELL_LAYOUT (cell_view)); gtk_widget_size_request (cell_view, &req); gtk_widget_show (cell_view); - - item = gtk_menu_item_new (); - gtk_container_add (GTK_CONTAINER (item), cell_view); return item; } -- 2.30.2